Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Zowe deps to fix handling of invalid ds member names #2807

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Update Zowe deps to fix handling of invalid ds member names #2807

merged 6 commits into from
Apr 10, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 27, 2024 •
edited
Loading

Proposed changes

Improves the way that invalid ds member names are handled. Before we tried to parse the invalid member names and replace control characters with �, which was prone to edge case problems. Now we stop parsing members after the first invalid member name is encountered, and add a fake member entry at the end that says "N members with errors" for the ones we are unable to display.
image

Release Notes

Milestone: 2.15.3

Changelog: Fixed error that could occur when listing data set members that contain control characters in the name

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.29%. Comparing base (6346758) to head (fc9a695).
Report is 3 commits behind head on maintenance.

❗ Current head fc9a695 differs from pull request most recent head e4ee8ce. Consider uploading reports for the commit e4ee8ce to get more accurate results

Files Patch % Lines
packages/zowe-explorer/src/shared/init.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           maintenance    #2807      +/-   ##
===============================================
- Coverage        93.29%   93.29%   -0.01%     
===============================================
  Files              103      103              
  Lines            10655    10665      +10     
  Branches          2316     2231      -85     
===============================================
+ Hits              9941     9950       +9     
- Misses             713      714       +1     
  Partials             1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review April 2, 2024 21:29
@t1m0thyj t1m0thyj force-pushed the fix/invalid-member-names branch from 6654481 to ecf5611 Compare April 3, 2024 03:50
awharn
awharn previously approved these changes Apr 4, 2024
View reviewed changes
zFernand0
zFernand0 previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 😋
Thanks for updating the icons too 😋

@t1m0thyj t1m0thyj dismissed stale reviews from zFernand0 and awharn via 63b12e3 April 9, 2024 14:34
@t1m0thyj t1m0thyj force-pushed the fix/invalid-member-names branch from 63b12e3 to ecf5611 Compare April 9, 2024 14:35
@t1m0thyj t1m0thyj added this to the v2.15.3 milestone Apr 9, 2024
t1m0thyj and others added 4 commits April 9, 2024 20:16
@t1m0thyj
Update Zowe deps to fix handling of invalid ds member names
bd621b4 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj @traeok
Improve UX for ds members with errors
decd90a 
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Fix unit tests for dataset nodes
bc195be 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Update cli dependency to 7.24.0
19fa477 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj force-pushed the fix/invalid-member-names branch from ecf5611 to 5edcd3e Compare April 10, 2024 00:19
@t1m0thyj t1m0thyj changed the base branch from main to maintenance April 10, 2024 00:19
@t1m0thyj
Update changelog
fc9a695 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj force-pushed the fix/invalid-member-names branch 2 times, most recently from f1f13f0 to 69876ad Compare April 10, 2024 00:47
zFernand0
zFernand0 previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing and updating the lockfile. 🥳
Seems like all build-related checks passed
image

LGTM! 😋

@t1m0thyj
Update lockfile after rebase to fix audit
e4ee8ce 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj force-pushed the fix/invalid-member-names branch from 69876ad to e4ee8ce Compare April 10, 2024 13:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

zFernand0
zFernand0 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

JillieBeanSim
JillieBeanSim approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @t1m0thyj

@t1m0thyj t1m0thyj merged commit f3f9ea7 into maintenance Apr 10, 2024
9 of 10 checks passed
@t1m0thyj t1m0thyj deleted the fix/invalid-member-names branch April 10, 2024 15:00
@JillieBeanSim JillieBeanSim mentioned this pull request Apr 16, 2024
Closed
This was referenced Sep 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awharn awharn awharn approved these changes

@JillieBeanSim JillieBeanSim JillieBeanSim approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@traeok traeok Awaiting requested review from traeok

@rudyflores rudyflores Awaiting requested review from rudyflores

@SanthoshiBoyina SanthoshiBoyina Awaiting requested review from SanthoshiBoyina

@likhithanimma1 likhithanimma1 Awaiting requested review from likhithanimma1

Assignees

@t1m0thyj t1m0thyj

Labels
None yet
Projects
None yet
Milestone
v2.15.3
Development

Successfully merging this pull request may close these issues.
4 participants
@t1m0thyj @zFernand0 @JillieBeanSim @awharn